Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.license-expression: fix build #69211

Merged
merged 2 commits into from Sep 23, 2019
Merged

pythonPackages.license-expression: fix build #69211

merged 2 commits into from Sep 23, 2019

Conversation

yorickvP
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kirelagin

@yorickvP
Copy link
Contributor Author

Fixed!

@Mic92 Mic92 merged commit f5cb9bd into NixOS:master Sep 23, 2019
@yorickvP yorickvP deleted the patch-3 branch September 23, 2019 12:21
@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

[detached HEAD 82e1d6f] pythonPackages.license-expression: fix build
Author: Yorick yorick@yorickvanpelt.nl
Date: Sat Sep 21 15:10:41 2019 +0200
1 file changed, 1 insertion(+)
Press Enter to continue
[detached HEAD 05f275f] pythonPackages.license-expression: make patchShebangs more specific
Author: Yorick yorick@yorickvanpelt.nl
Date: Mon Sep 23 13:50:31 2019 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @Mic92 @worldofpeace