Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k9s: 0.7.13 -> 0.8.4 #69230

Merged
merged 1 commit into from Sep 22, 2019
Merged

k9s: 0.7.13 -> 0.8.4 #69230

merged 1 commit into from Sep 22, 2019

Conversation

thoughtpolice
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
Notify maintainers

cc @Gonzih

@thoughtpolice
k9s: 0.7.13 -> 0.8.4
484d809 
Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice self-assigned this Sep 21, 2019
@ofborg ofborg bot requested a review from kalbasit September 21, 2019 22:57
jonringer
jonringer approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

Gonzih
Gonzih approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@Gonzih Gonzih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested via nix-review

@thoughtpolice thoughtpolice merged commit 3c10b93 into NixOS:master Sep 22, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/k9s-update branch September 22, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonzih Gonzih Gonzih approved these changes

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees

@thoughtpolice thoughtpolice

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thoughtpolice @Gonzih @jonringer