Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated overrides for haskellPackages.PyF and haskellPackages.MemoTrie #69246

Merged
merged 2 commits into from Sep 23, 2019
Merged

Remove outdated overrides for haskellPackages.PyF and haskellPackages.MemoTrie #69246

merged 2 commits into from Sep 23, 2019

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Sep 22, 2019

Motivation for this change

haskellPackages.PyF is marked as broken and haskellPackages.MemoTrie contains overrides which disable haddock documentation generation.

These overrides are no longer necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout
Copy link
Member

@guibou Thanks for making this change.

However, the hackage-packages.nix should not be modified. See this video for instructions:

https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968

Can you rebase this PR to remove the change in hackage-packages.nix?

I've confirmed that MemoTrie and PyF can be built, so after you do the above, we can get this PR merged in.

@guibou
haskellPackages.PyF: remove broken status
9073f1d 
PyF builds perfectly with `haskellPackages.PyF`
@guibou
haskellPackages.MemoTrie: remove dontCheck and dontHaddock overrides.
3ac7516 
It works fine with (at least):
  - haskellPackages.MemoTrie
  - haskellPackages.ghc844.MemoTrie
@guibou
Copy link
Contributor Author

guibou commented Sep 23, 2019

@cdepillabout Done: I removed the change to hackage-packages.nix. Thank you.

@cdepillabout
Copy link
Member

@guibou Thanks!

@peti These two packages build fine, so this PR should be ready to merge in.

@peti peti changed the base branch from master to haskell-updates September 23, 2019 11:22
@peti peti merged commit b255309 into NixOS:haskell-updates Sep 23, 2019
@ofborg ofborg bot removed the 6.topic: haskell label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guibou @cdepillabout @peti