Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordpress: new package version, generate secrets locally #69247

Merged
merged 2 commits into from Sep 22, 2019
Merged

wordpress: new package version, generate secrets locally #69247

merged 2 commits into from Sep 22, 2019

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Sep 22, 2019 •
edited

Motivation for this change

https://wordpress.org/news/2019/09/wordpress-5-2-3-security-and-maintenance-release/

The second commit also modifies the NixOS module to generate crypto keys locally instead of downloading them from https://api.wordpress.org/secret-key/1.1/salt/ which seems like bad security practice (although recommened by upstream). Feel free to merge just the package update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aanderse @FPtje

@ofborg ofborg bot requested a review from basvandijk September 22, 2019 12:54
@aanderse
Copy link
Member

@GrahamcOfBorg test wordpress

@aanderse
Copy link
Member

@mmilata thanks for this PR! Especially on the secret keys bit. I've never used wordpress before so just used upstream recommendations.

As far as the version bump goes I should really look at the logs @ryantm posts from his bot to understand why it didn't make this PR...

@aanderse
Copy link
Member

@mmilata ping me on backport to 19.09 please. Thank you very much! 🎉

@aanderse aanderse merged commit 25efd6c into NixOS:master Sep 22, 2019
@mmilata mmilata mentioned this pull request Sep 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @aanderse