lefthook: init at 0.6.3 #69233
Merged
lefthook: init at 0.6.3 #69233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Sep 22, 2019
marsam
reviewed
Sep 22, 2019
| pname = "lefthook"; | ||
| version = "0.6.3"; | ||
|
|
||
| goPackagePath = "github.com/Arkweid/lefthook"; |
There was a problem hiding this comment.
goPackagePath is not necessary for buildGoModule
Suggested change
| goPackagePath = "github.com/Arkweid/lefthook"; |
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Fast and powerful Git hooks manager for any type of projects"; | ||
| homepage = https://evilmartians.com/chronicles/lefthook-knock-your-teams-code-back-into-shape?utm_source=lefthook; |
There was a problem hiding this comment.
nitpick, I think it's better to point to the repository instead of a release post.
Suggested change
| homepage = https://evilmartians.com/chronicles/lefthook-knock-your-teams-code-back-into-shape?utm_source=lefthook; | |
| homepage = "https://github.com/Arkweid/lefthook"; |
pkgs/top-level/all-packages.nix
Outdated
| @@ -10227,6 +10227,9 @@ in | |||
|
|
|||
| nsis = callPackage ../development/tools/nsis { }; | |||
|
|
|||
| ### DEVELOPMENT / TOOLS / VERSION CONTROL | |||
| lefthook = callPackage ../development/tools/version-control/lefthook {}; | |||
There was a problem hiding this comment.
I would prefer this to be placed under ### DEVELOPMENT / EMSCRIPTEN; because pre-commit (same category) is under there
|
@marsam thanks for the suggestions, I've implemented some more changes, please review if necessary. |
|
Thanks! |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Sep 23, 2019
lefthook: init at 0.6.3 (cherry picked from commit 696b36f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds lefthook, a cli tool for managing git hooks.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @