Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lefthook: init at 0.6.3 #69233

Merged
merged 4 commits into from
Sep 22, 2019
Merged

lefthook: init at 0.6.3 #69233

merged 4 commits into from
Sep 22, 2019
+26 −0

Conversation

rencire
Copy link
Contributor

@rencire rencire commented Sep 22, 2019 •
edited
Loading

Motivation for this change

Adds lefthook, a cli tool for managing git hooks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [] Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@rencire
lefthook: init at 0.6.3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2628492
@rencire
removed extra period

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7c6c876
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 22, 2019
@ofborg ofborg bot requested a review from kalbasit September 22, 2019 01:24
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 22, 2019
jonringer
jonringer approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary works
leaf package

marsam
marsam reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a pair of comment. Besides that, LTGM

pkgs/development/tools/version-control/lefthook/default.nix Outdated
pname = "lefthook";
version = "0.6.3";

goPackagePath = "github.com/Arkweid/lefthook";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goPackagePath is not necessary for buildGoModule

Suggested change
goPackagePath = "github.com/Arkweid/lefthook";

pkgs/development/tools/version-control/lefthook/default.nix Outdated

meta = with stdenv.lib; {
description = "Fast and powerful Git hooks manager for any type of projects";
homepage = https://evilmartians.com/chronicles/lefthook-knock-your-teams-code-back-into-shape?utm_source=lefthook;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, I think it's better to point to the repository instead of a release post.

Suggested change
homepage = https://evilmartians.com/chronicles/lefthook-knock-your-teams-code-back-into-shape?utm_source=lefthook;
homepage = "https://github.com/Arkweid/lefthook";

pkgs/top-level/all-packages.nix Outdated
@@ -10227,6 +10227,9 @@ in

nsis = callPackage ../development/tools/nsis { };

### DEVELOPMENT / TOOLS / VERSION CONTROL
lefthook = callPackage ../development/tools/version-control/lefthook {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this to be placed under ### DEVELOPMENT / EMSCRIPTEN; because pre-commit (same category) is under there

@rencire
Copy link
Contributor Author

rencire commented Sep 22, 2019

@marsam thanks for the suggestions, I've implemented some more changes, please review if necessary.

@marsam marsam merged commit 696b36f into NixOS:master Sep 22, 2019
@marsam
Copy link
Contributor

marsam commented Sep 22, 2019

Thanks!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2019
@rencire @dtzWill
lefthook: init at 0.6.3 (NixOS#69233)
493f052 
lefthook: init at 0.6.3
(cherry picked from commit 696b36f)
@rencire rencire deleted the add-lefthook branch September 23, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@jonringer jonringer

@kalbasit kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rencire @marsam @jonringer