Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cairocffi: v1.0.2 -> v.1.1.0 #69256

Merged
merged 1 commit into from Sep 23, 2019
Merged

pythonPackages.cairocffi: v1.0.2 -> v.1.1.0 #69256

merged 1 commit into from Sep 23, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

Fixes: #69126
Related to: #68361

The tests were failing due the switch to pytest5.
This issue has been addressed upstream in
Kozea/cairocffi@a500f20
which is included in v.1.1.0, so bumping the version and
updating the old patch.

Hydra log of the failure:
https://hydra.nixos.org/build/100785460/nixlog/6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @avnik

@d-goldin
pythonPackages.cairocffi: v1.0.2 -> v.1.1.0
7ff2638 
The tests were failing due the switch to pytest5.
This issue has been addressed upstream in
Kozea/cairocffi@a500f20
which is included in v.1.1.0, so bumping the version and
updating the old patch.

Hydra log of the failure:
https://hydra.nixos.org/build/100785460/nixlog/6
ghost
ghost approved these changes Sep 23, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me, thanks!

avnik
avnik approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
I prepared similar patch, but you was few hours faster.

@avnik
Copy link
Contributor

avnik commented Sep 23, 2019

btw folks, I like to simplify _LIBS content to "@cairo@", and try to offer patch to upstream (with fallback to cffi.find_library if it still starts from "@". It can be useful by other distros, where library location is pre-known.

@Mic92 Mic92 merged commit 8644268 into NixOS:master Sep 23, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

@avnik sounds good.

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

[detached HEAD 408b7e4] pythonPackages.cairocffi: v1.0.2 -> v.1.1.0
Author: Dima dgoldin+github@protonmail.ch
Date: Sun Sep 22 16:27:36 2019 +0200
2 files changed, 63 insertions(+), 48 deletions(-)
rewrite pkgs/development/python-modules/cairocffi/dlopen-paths.patch (64%)

@d-goldin d-goldin deleted the cairocffi_bump branch September 23, 2019 20:18
@JohnAZoidberg JohnAZoidberg mentioned this pull request Sep 25, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnik avnik avnik approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.cairocffi is broken
3 participants
@d-goldin @avnik @Mic92