breeze-plymouth: allow usage of custom logo #69357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Very sensible, I like it. Not sure why I didn't do this to begin with...
Given that the logo file gets copied into etc in the main module, do we actually need to put it into the theme? I think we do, which is the reason I did it, but worth checking whether we need both.
mtetreault
force-pushed
the
plymouth-custom-logo
branch
from
c5015b9
to
0725341
Compare
michaelpj
reviewed
Sep 25, 2019
|
Looks like the logo does indeed need to be in there: https://github.com/KDE/breeze-plymouth/blob/f775fdc322d4bfca46c61871b1e7f9c64df0d9d6/breeze/breeze.script.cmake#L46 |
mtetreault
force-pushed
the
plymouth-custom-logo
branch
from
0725341
to
2bbcf4b
Compare
michaelpj
reviewed
Sep 26, 2019
michaelpj
approved these changes
Sep 26, 2019
mtetreault
force-pushed
the
plymouth-custom-logo
branch
from
2bbcf4b
to
07a429e
Compare
|
@mtetreault One more thing: could you please rebase this pull request onto |
mtetreault
force-pushed
the
plymouth-custom-logo
branch
from
07a429e
to
11435dd
Compare
mtetreault
force-pushed
the
plymouth-custom-logo
branch
from
11435dd
to
001b42d
Compare
|
@ttuegel: I rebased the pull request onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Default plymouth theme was changed to breeze by: michaelpj/nixpkgs@96da47d.
IMHO this new default look way nicer than the "fade-in" theme. However, this modification breaks the logo option from the plymouth package.
Breeze-Plymouth have been modified to accept more customization throught overridde.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @michaelpj @orivej