Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breeze-plymouth: allow usage of custom logo #69357

Merged
merged 1 commit into from
Oct 8, 2019
Merged

breeze-plymouth: allow usage of custom logo #69357

merged 1 commit into from
Oct 8, 2019
+33 −28

Conversation

mtetreault
Copy link

Motivation for this change

Default plymouth theme was changed to breeze by: michaelpj/nixpkgs@96da47d.

IMHO this new default look way nicer than the "fade-in" theme. However, this modification breaks the logo option from the plymouth package.

Breeze-Plymouth have been modified to accept more customization throught overridde.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via plasma5.nix NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @michaelpj @orivej

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 24, 2019
michaelpj
michaelpj approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sensible, I like it. Not sure why I didn't do this to begin with...

Given that the logo file gets copied into etc in the main module, do we actually need to put it into the theme? I think we do, which is the reason I did it, but worth checking whether we need both.

@michaelpj
Copy link
Contributor

Looks like the logo does indeed need to be in there: https://github.com/KDE/breeze-plymouth/blob/f775fdc322d4bfca46c61871b1e7f9c64df0d9d6/breeze/breeze.script.cmake#L46

michaelpj
michaelpj approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit, then LGTM!

@ttuegel
Copy link
Member

ttuegel commented Sep 28, 2019

@mtetreault One more thing: could you please rebase this pull request onto master branch, and we will backport it to the release branch?

@mtetreault mtetreault changed the base branch from release-19.03 to master September 30, 2019 13:32
@mtetreault mtetreault force-pushed the plymouth-custom-logo branch from 11435dd to 001b42d Compare October 7, 2019 13:46
@mtetreault
Copy link
Author

@ttuegel: I rebased the pull request onto master as requested

@ttuegel ttuegel merged commit 22b4014 into NixOS:master Oct 8, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj

@infinisil infinisil

@ttuegel ttuegel

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtetreault @michaelpj @ttuegel @Janik-Haag