Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piper: temporarily propagate gobject-introspection [19.09 backport] #69355

Merged
merged 1 commit into from Sep 24, 2019
Merged

piper: temporarily propagate gobject-introspection [19.09 backport] #69355

merged 1 commit into from Sep 24, 2019

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 24, 2019 •
edited

Motivation for this change
Things done

Piper in 19.09 is currently affected by #56943, so propagate gobject-introspection as a temporariy workaround.

This is the same workaround merged into master in #69120 by @Mic92.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mvnetbiz

@mweinelt
piper: temporarily propagate gobject-introspection
5ada0bf 
On startup piper would be unable to find Pango:
> ImportError: Typelib file for namespace 'Pango', version '1.0' not found

Workaround for NixOS#56943

(cherry picked from commit fb9b744)
@ofborg ofborg bot requested a review from mvnetbiz September 24, 2019 13:17
@Mic92 Mic92 merged commit ec57b2c into NixOS:release-19.09 Sep 24, 2019
@mweinelt mweinelt deleted the pr/piper/gobjectintrospection branch February 24, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvnetbiz mvnetbiz Awaiting requested review from mvnetbiz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @Mic92