Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mucommander: 0.9.2 -> 0.9.3-3 #69280

Merged
merged 1 commit into from Sep 23, 2019
Merged

mucommander: 0.9.2 -> 0.9.3-3 #69280

merged 1 commit into from Sep 23, 2019

Conversation

avdv
Copy link
Member

@avdv avdv commented Sep 23, 2019

Motivation for this change

Fixes mucommander build https://hydra.nixos.org/build/100445767

#68361

Mucommander 0.9.3-3 was released in Dec 2018.

  • comment out proguard.enabled = ... in build.gradle
  • use Gradle 4.10 (upstream uses 4.8)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from volth September 23, 2019 07:59
Mic92
Mic92 reviewed Sep 23, 2019
View reviewed changes
pkgs/applications/misc/mucommander/default.nix Outdated
rev = version;
sha256 = "1fvij0yjjz56hsyddznx7mdgq1zm25fkng3axl03iyrij976z7b8";
rev = "${version}-${patch}";
sha256 = "13yks3lalla4jpbl9qnvi4swmp049yibga1kmqpbjda08adi4cn1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the a different checksum:

hash mismatch in fixed-output derivation '/nix/store/ls186qmbqva0jkxq2p8xclwhgbl3fa35-source':
  wanted: sha256:13yks3lalla4jpbl9qnvi4swmp049yibga1kmqpbjda08adi4cn1
  got:    sha256:1zhglsx3b5k6np3ppfkkrqz9wg0j7ip598xxfgn75gjl020w0can

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I was tripped by the fact that I had used tag 0.9.3 before realizing they released patch versions, like 0.9.3-1 and so forth.

Also, they released 0.9.3-3, but the version inside the build.gradle file says 0.9.4... yuck.

I'll fix this.

@avdv
mucommander: 0.9.2 -> 0.9.3-3
308617e 
Mucommander 0.9.3-3 was released in January 2019.

* comment out `proguard.enabled = ...` in build.gradle
* use Gradle 4.10 (upstream uses 4.8)
* fix version in build.gradle
@Mic92 Mic92 merged commit a2be11b into NixOS:master Sep 23, 2019
@avdv avdv mentioned this pull request Sep 27, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avdv @Mic92