Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
base: 2dc6ae4ac531
Choose a base ref
...
head repository: m-labs/nmigen
compare: 3d62dac1cbc3
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Sep 21, 2019

  1. build.plat: NMIGEN_<toolchain>_env→NMIGEN_ENV_<toolchain> 

    This is more consistent with other environment variables nMigen uses.
    whitequark committed Sep 21, 2019
    Copy the full SHA
    07a82ed View commit details
    Browse the repository at this point in the history

  2. build.res: simplify clock constraints. 

    Before this commit, it was possible to set and get clock constraints
placed on Pin objects. This was not a very good implementation, since
it relied on matching the identity of the provided Pin object to
a previously requested one. The only reason it worked like that is
deficiencies in nextpnr.

Since then, nextpnr has been fixed to allow setting constraints on
arbitrary nets. Correspondingly, backends that are using Synplify
were changed to use [get_nets] instead of [get_ports] in SDC files.
However, in some situations, Synplify does not allow specifying
ports in [get_nets]. (In fact, nextpnr had a similar problem, but
it has also been fixed.)

The simplest way to address this is to refer to the interior net
(after the input buffer), which always works. The only downside
of this is that requesting a clock as a raw pin using
    platform.request("clk", dir="-")
and directly applying a constraint to it could fail in some cases.
This is not a significant issue.
    whitequark committed Sep 21, 2019
    Copy the full SHA
    8050cfa View commit details
    Browse the repository at this point in the history

  3. vendor.lattice_ice40: add iCECube support. 

    This also makes some iCE40 and ECP5 overrides more consistent.
    whitequark committed Sep 21, 2019
    Copy the full SHA
    3d62dac View commit details
    Browse the repository at this point in the history