Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: 6.2.2 -> 6.2.4 #69207

Merged
merged 1 commit into from Oct 2, 2019
Merged

rocksdb: 6.2.2 -> 6.2.4 #69207

merged 1 commit into from Oct 2, 2019

Conversation

magenbluten
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from adevress September 21, 2019 11:28
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

@GrahamcOfBorg build rocksdb

@Lassulus
Copy link
Member

Lassulus commented Oct 2, 2019

ok, everything except osquery and bareos build successfully, but the 2 are marked as broken, so I think we are good to merge

@Lassulus Lassulus merged commit 0cd8882 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adevress adevress Awaiting requested review from adevress

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magenbluten @Mic92 @Lassulus