Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpcui: 0.2.0 -> 0.2.1 #68942

Merged
merged 1 commit into from Sep 24, 2019
Merged

grpcui: 0.2.0 -> 0.2.1 #68942

merged 1 commit into from Sep 24, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pradyuman

@ofborg ofborg bot requested review from pradyuman and kalbasit September 16, 2019 21:22
@ofborg ofborg bot requested a review from pradyuman September 17, 2019 20:04
@kalbasit
Copy link
Member

@GrahamcOfBorg build grpcui

@kalbasit
Copy link
Member

ofborg is reporting a different hash for the go modules.

@rvolosatovs
Copy link
Member Author

That's an instance of #68135 (comment)

@ofborg ofborg bot requested a review from pradyuman September 21, 2019 08:52
@Mic92 Mic92 merged commit f611355 into NixOS:master Sep 24, 2019
@rvolosatovs rvolosatovs deleted the update/grpcui branch September 24, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@pradyuman pradyuman Awaiting requested review from pradyuman

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @kalbasit @pradyuman @Mic92