Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afew: propagate setuptools #69250

Merged
merged 1 commit into from Sep 22, 2019
Merged

afew: propagate setuptools #69250

merged 1 commit into from Sep 22, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 22, 2019

Motivation for this change

afew fails to run on current master, as setuptools isn't propagated anymore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92 Mic92 merged commit 3f46dd4 into NixOS:master Sep 22, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 22, 2019

[detached HEAD 88f32cc] afew: propagate setuptools
Author: Florian Klink flokli@flokli.de
Date: Sun Sep 22 16:09:08 2019 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

@flokli flokli deleted the afew-setuptools branch September 22, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@globin globin Awaiting requested review from globin

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Mic92