New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: 0.29.0 -> 1.0.0 #69252
bazel: 0.29.0 -> 1.0.0 #69252
Conversation
Sorry, I should have created a "draft" PR. This should not be merged until bazel 1.0 is official. |
@GrahamcOfBorg build bazel.tests |
@guibou marking it as draft is a good idea. |
Bazel 1.0 was released: https://blog.bazel.build/2019/10/10/bazel-1.0.html I no longer consider this PR as work in progress. |
@GrahamcOfBorg build bazel.tests |
We’ll have to fix the darwin build now:
@kalbasit, @uri-canva any input? |
Maybe we should fix/expand this 👇? nixpkgs/pkgs/development/tools/build-managers/bazel/default.nix Lines 309 to 313 in 73eb01b
|
@GrahamcOfBorg build bazel |
bazelbuild/bazel@ada2c55 introduced explicit I pushed a commit on top of it which should fix the two currently not matching occurences in I'm not sure why we need this in first place - passing another compiler to use instead of xcrun should be something supported upstreamed somehow by |
@GrahamcOfBorg build bazel.tests |
I opened bazelbuild/bazel#9993 about using |
|
This smells like the same error as in #66723 (comment), so pinging @aherrmann here - this might already be halfway broken in master on Darwin, the version bump now just exercises more code paths. What do you think about merging this PR into master as-is, rebasing #66723 on top of it, and fix the darwin problems in there too? |
Oh wow, you are right! |
In accordance with @flokli I’ll merge and we are going to open an issue about the MacOS thing. |
I opened a follow-up issue for the broken MacOS tests in #70994. |
Motivation for this change
Update bazel to upstream version.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @Profpatsch