Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tks: init at 1.0.32 #69341

Closed
wants to merge 2 commits into from
Closed

tks: init at 1.0.32 #69341

wants to merge 2 commits into from
+106 −0

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Sep 24, 2019

Motivation for this change

Add TKS, a command line tool and more for managing time sheets for work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" N/A
  • Tested execution of all binary files (usually in ./result/bin/). tks-weekly-prep does not run due to a missing Scriptalicious.pm, but that can be fixed at a later time.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 24, 2019
Mic92
Mic92 reviewed Sep 24, 2019
View reviewed changes
pkgs/applications/office/tks/default.nix
nativeBuildInputs = [ dpkg makeWrapper ];
buildInputs = [ perlEnv ];

unpackPhase = "dpkg-deb -x ${src} .";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it not possible to build it from source?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sources: https://github.com/shoptime/tks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 I'll try, but the Debian build system is … not the easiest to pull apart.

@peterhoeg That repo is years out of date.

l0b0 added 2 commits October 10, 2019 08:41
@l0b0 @victor-catalyst
Maintainers: add l0b0
46285a8
@l0b0 @victor-catalyst
tks: init at 1.0.32
b707da1 
Timekeeping sucks, TKS makes it suck less. You can keep track of your
time in a human-readable file, then run a script to import the data
straight into your timekeeping system.
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000 SuperSandro2000 changed the title TKS (Time Keeping Sucks) tks: init at 1.0.32 Jan 18, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/applications/office/tks/default.nix
Comment on lines +88 to +93
meta = {
description = "Timekeeping sucks, TKS makes it suck less";
license = stdenv.lib.licenses.gpl3;
platforms = stdenv.lib.platforms.linux;
maintainers = [ stdenv.lib.maintainers.l0b0 ];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
description = "Timekeeping sucks, TKS makes it suck less";
license = stdenv.lib.licenses.gpl3;
platforms = stdenv.lib.platforms.linux;
maintainers = [ stdenv.lib.maintainers.l0b0 ];
};
meta = with lib; {
description = "Timekeeping sucks, TKS makes it suck less";
license = licenses.gpl3;
platforms = platforms.linux;
maintainers = [ maintainers.l0b0 ];
};

gpl3Plus or gpl3Only?

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@Mic92
Copy link
Member

Mic92 commented Jul 21, 2021

closing because it got stalled. Please open a new PR if there is still interest.

@Mic92 Mic92 closed this Jul 21, 2021
@l0b0 l0b0 deleted the tks branch July 25, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@peterhoeg peterhoeg

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@l0b0 @Mic92 @peterhoeg @SuperSandro2000