Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: make sysinit.target depend on local-fs.target again [backport] #69285

Merged
merged 2 commits into from Sep 23, 2019
Merged

systemd: make sysinit.target depend on local-fs.target again [backport] #69285

merged 2 commits into from Sep 23, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
systemd: make sysinit.target depend on local-fs.target again
9bc836c 
This change was re-introduced when updating to systemd 243.
Also see: NixOS#67858

(cherry picked from commit 53fb1c5)
@Mic92
systemd: add myself as maintainer
cf97c54 
(cherry picked from commit 1e87723)
@Mic92
Copy link
Member Author

Mic92 commented Sep 23, 2019

see #69284 and #69253 (comment)

@ofborg ofborg bot requested review from andir and edolstra September 23, 2019 09:03
@Mic92 Mic92 merged commit 6c0d878 into NixOS:staging-19.09 Sep 23, 2019
@Mic92 Mic92 deleted the systemd-local-fs-backport branch September 23, 2019 09:37
@flokli flokli mentioned this pull request Sep 23, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92