Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 0.68.131 -> 0.69.128 #69283

Merged
merged 1 commit into from Sep 24, 2019
Merged

brave: 0.68.131 -> 0.69.128 #69283

merged 1 commit into from Sep 24, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented Sep 23, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @uskudnik

@ofborg ofborg bot requested a review from uskudnik September 23, 2019 09:46
@Mic92 Mic92 merged commit f121c52 into master Sep 24, 2019
@Mic92 Mic92 deleted the update-brave-browser branch September 24, 2019 03:01
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

[detached HEAD e102f87] brave: 0.68.131 -> 0.69.128
Author: Pascal Wittmann mail@pascal-wittmann.de
Date: Mon Sep 23 10:34:49 2019 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pSub @Mic92