Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init shiori #69255

Merged
merged 2 commits into from Oct 12, 2019
Merged

Init shiori #69255

merged 2 commits into from Oct 12, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

Shiori, the simple bookmarks manager. I don't know much about the Go programming lanuage, and much less how to package it. Please tell me if there could be improvements.

This PR comes with a module and a test for the module

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 22, 2019 16:13
alexarice
alexarice reviewed Sep 22, 2019
View reviewed changes
nixos/modules/services/web-apps/shiori.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/shiori.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/shiori.nix Outdated Show resolved Hide resolved
pkgs/servers/web-apps/shiori/default.nix
@@ -0,0 +1,22 @@
{ stdenv, buildGoModule, fetchFromGitHub }:

buildGoModule rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #69229. I think buildGoPackage is preferred, though I also know little about go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried with buildGoPackage, but it failed after compilation and tests succeeded :-/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never used either so cannot really help. I just remembered seeing the pr I linked earlier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems lots of other prs are using buildGoModule, so I wouldn't worry about it unless someone else suggests changing it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the Nixpkgs documentation does say that:

The function buildGoPackage builds legacy Go programs, not supporting Go modules.

This gives the impression that buildGoModule is preferred ^^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure does

@minijackson
Copy link
Member Author

Thanks for all the feedback, @alexarice !

@alexarice
Copy link
Contributor

@GrahamcOfBorg build shiori

alexarice
alexarice approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and test passes with nix-review

@marsam marsam merged commit af4351a into NixOS:master Oct 12, 2019
@marsam
Copy link
Contributor

marsam commented Oct 12, 2019

Thanks @minijackson and @alexarice

@minijackson minijackson deleted the init-shiori branch April 8, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @alexarice @marsam