Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcerf: 1.5 -> 1.13 #69218

Merged
merged 1 commit into from Nov 29, 2019
Merged

libcerf: 1.5 -> 1.13 #69218

merged 1 commit into from Nov 29, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Sep 21, 2019 •
edited

Upstream has moved the src tarball download location and homepage for libcerf,
so the current package is broken. While fixing it, let's upgrade to the latest
version, which is built with cmake now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @orivej

@bhipple
Copy link
Contributor Author

bhipple commented Sep 21, 2019

@GrahamcOfBorg build libcerf

jonringer
jonringer reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally the "v" prefix is left off in nixpkgs when specifying the version of the package, as it already is in a context that it's understood to be the version.

Also, I seem to get a build error now:

In file included from /build/cef_binary_3.3497.1833.g13f506f_linux64/libcef_dll/ctocpp/browser_ctocpp.h:28,
                 from /build/cef_binary_3.3497.1833.g13f506f_linux64/libcef_dll/cpptoc/display_handler_cpptoc.cc:16:
/build/cef_binary_3.3497.1833.g13f506f_linux64/libcef_dll/ctocpp/ctocpp_ref_counted.h:77:27: error: 'cfi-icall' attribute directive ignored [-Werror=attributes]
   void UnderlyingAddRef() const {
                           ^~~~~
/build/cef_binary_3.3497.1833.g13f506f_linux64/libcef_dll/ctocpp/ctocpp_ref_counted.h:85:28: error: 'cfi-icall' attribute directive ignored [-Werror=attributes]
   bool UnderlyingRelease() const {
                            ^~~~~
/build/cef_binary_3.3497.1833.g13f506f_linux64/libcef_dll/ctocpp/ctocpp_ref_counted.h:94:30: error: 'cfi-icall' attribute directive ignored [-Werror=attributes]
   bool UnderlyingHasOneRef() const {
                              ^~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [libcef_dll_wrapper/CMakeFiles/libcef_dll_wrapper.dir/build.make:362: libcef_dll_wrapper/CMakeFiles/libcef_dll_wrapper.dir/cpptoc/display_handler_cpptoc.cc.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:106: libcef_dll_wrapper/CMakeFiles/libcef_dll_wrapper.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:113: libcef_dll_wrapper/CMakeFiles/libcef_dll_wrapper.dir/rule] Error 2
make: *** [Makefile:118: libcef_dll_wrapper] Error 2
builder for '/nix/store/s6yhkwy7d5hp57iq38sbgyk4620wl3hy-cef-binary-3.3497.1833.g13f506f.drv' failed with exit code 2
error: build of '/nix/store/s6yhkwy7d5hp57iq38sbgyk4620wl3hy-cef-binary-3.3497.1833.g13f506f.drv' failed

pkgs/development/libraries/libcerf/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libcerf/default.nix Outdated Show resolved Hide resolved
@bhipple
Copy link
Contributor Author

bhipple commented Oct 6, 2019 •
edited

Thanks for catching the superfluous v on version. It seems to build fine for me on Linux NixOS with sandboxing; are you on Darwin?

I'm re-running nix-review to see, and I also rebased it onto the lastest master with your suggested change.

@bhipple @jonringer
libcerf: 1.5 -> 1.13
447e19f 
Upstream has moved the src tarball download location and homepage for `libcerf`,
so the current package is broken. While fixing it, let's upgrade to the latest
version, which is built with cmake now.

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
c0bw3b
c0bw3b approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 69218 1

2 package were build:
  • gnuplot (libsForQt512.khotkeys ,plasma5.kde-cli-tools ,plasma5.kdeplasma-addons ,libsForQt5.khotkeys ,plasma5.kmenuedit ,plasma5.plasma-desktop ,plasma5.plasma-workspace ,plasma5.powerdevil ,plasma5.systemsettings)
  • libcerf (libsForQt512.khotkeys ,plasma5.kde-cli-tools ,plasma5.kdeplasma-addons ,libsForQt5.khotkeys ,plasma5.kmenuedit ,plasma5.plasma-desktop ,plasma5.plasma-workspace ,plasma5.powerdevil ,plasma5.systemsettings)

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2019

cef-binary build failure was fixed in #72190

@c0bw3b c0bw3b merged commit c9824f0 into NixOS:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @c0bw3b @jonringer