Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt: 1.2.8 -> 1.3.2 #69327

Merged
merged 4 commits into from Sep 27, 2019
Merged

sbt: 1.2.8 -> 1.3.2 #69327

merged 4 commits into from Sep 27, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Sep 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from NeQuissimus September 23, 2019 21:55
@regadas regadas changed the title Update sbt to 1.3.2 sbt: 1.2.8 -> 1.3.2 Sep 23, 2019

src = fetchurl {
urls = [
"https://dl.bintray.com/sbt/native-packages/sbt/${version}/${pname}-${version}.tgz"
"https://github.com/sbt/sbt/releases/download/v${version}/sbt-${version}.tgz"
"https://cocl.us/sbt-${version}.tgz"
];
sha256 = "0n7yghnb1q3lyjpv721znvslk5lwib7y84mxwz66yv8p84jj3fcv";
sha256 = "1ncjc4yrnhp2kc5xw3ismnyx5n71541760rzs81hxi8x8vi36x5b";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a different hash:

hash mismatch in fixed-output derivation '/nix/store/v8f3lbkzkr5gjkm6m794xhzrqfnnpmiz-sbt-1.3.2.tgz':
  wanted: sha256:1ncjc4yrnhp2kc5xw3ismnyx5n71541760rzs81hxi8x8vi36x5b
  got:    sha256:0vrj9wlw5kf6w7nzhf58dyik0n7rnc9aivjpsz85m299j4wyz37d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 interesting ... not sure if this is the correct way to get the hash:

nix-prefetch-url --unpack https://github.com/sbt/sbt/releases/download/v1.3.2/sbt-1.3.2.tgz
unpacking...
[49.4 MiB DL]
path is '/nix/store/2mvik6xvnas8s3i8c78lmlljq15a2g3l-sbt-1.3.2.tgz'
1ncjc4yrnhp2kc5xw3ismnyx5n71541760rzs81hxi8x8vi36x5b

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regadas is it possible that the bintray archive is different from the github one?

Copy link
Contributor Author

@regadas regadas Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mic92 it's definitely possible; however only the github link is being updated with the latest releases the others will just 404; I think we should just keep the github one, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regadas yes. drop the other ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 hmm,

nix-prefetch-url --unpack https://piccolo.link/sbt-1.3.2.tgz    unpacking...
path is '/nix/store/2mvik6xvnas8s3i8c78lmlljq15a2g3l-sbt-1.3.2.tgz'
1ncjc4yrnhp2kc5xw3ismnyx5n71541760rzs81hxi8x8vi36x5b

nix-prefetch-url --unpack https://github.com/sbt/sbt/releases/download/v1.3.2/sbt-1.3.2.tgz      
unpacking...
path is '/nix/store/2mvik6xvnas8s3i8c78lmlljq15a2g3l-sbt-1.3.2.tgz'
1ncjc4yrnhp2kc5xw3ismnyx5n71541760rzs81hxi8x8vi36x5b

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a better look at this later ... looks like smth else might be broken?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofborg also shows a different checksum: https://logs.nix.ci/?key=nixos/nixpkgs.69327&attempt_id=91c42493-27e4-4271-8664-3e6aa9c037fd

Can you build the package manually?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. You should not use --unpack when fetchurl is used. Fetchurl is calculating the checksum of the tarball and not of the directory content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok! i thought it would check the content ... good to know 👍

@regadas
Copy link
Contributor Author

regadas commented Sep 25, 2019

@Mic92 should be good now!

@Mic92
Copy link
Member

Mic92 commented Sep 26, 2019

@GrahamcOfBorg build sbt

@regadas
Copy link
Contributor Author

regadas commented Sep 27, 2019

@GrahamcOfBorg build sbt

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Sep 27, 2019

@GrahamcOfBorg build sbt

@Mic92 Mic92 merged commit 7ec88c7 into NixOS:master Sep 27, 2019
@regadas regadas deleted the update/sbt branch September 27, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants