Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.1.6 -> 12.3.0 #69325

Closed
wants to merge 15 commits into from
Closed

gitlab: 12.1.6 -> 12.3.0 #69325

wants to merge 15 commits into from
+4,580 −809

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Sep 23, 2019

Motivation for this change

This is an updated version of #68777

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@bgamari
Copy link
Contributor Author

bgamari commented Sep 23, 2019

@test gitlab

@bgamari bgamari mentioned this pull request Sep 23, 2019
Closed
10 tasks
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 23, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg test gitlab

@bgamari
Copy link
Contributor Author

bgamari commented Sep 24, 2019

This appears to be broken due to https://gitlab.com/gitlab-org/gitlab-shell/issues/211.

@flokli flokli added 1.severity: blocker This is preventing another PR or issue from being completed 1.severity: security Issues which raise a security issue, or PRs that fix one labels Sep 24, 2019
@flokli
Copy link
Contributor

flokli commented Sep 24, 2019

@bgamari do you think we can workaround the upstream vendored/non-vendored grpc issue? I'd really like to have ship a version containing all CVE-related fixes to 19.09…

@flokli flokli requested a review from globin September 24, 2019 12:40
@bgamari
Copy link
Contributor Author

bgamari commented Sep 24, 2019

@flokli I honestly have no idea. The GitLab folks seem to think that there is no bug but my very limited knowledge of Go's packaging system makes it very hard for me to tell. Do we perhaps have someone with a deeper knowledge of Go who could have a look?

@flokli
Copy link
Contributor

flokli commented Sep 24, 2019 via email

@ghost
Copy link

ghost commented Oct 1, 2019

Any news? It is currently impossible to set up a gitlab-ee instance, because the old gitlab-ee version was removed from the repository.

@ghost
Copy link

ghost commented Oct 1, 2019

@bgamari did you forget to commit some things? I can not build gitlab-shell for multiple reasons. The patch could not be applied, and then it complained about missing "rubocop".

@bgamari
Copy link
Contributor Author

bgamari commented Oct 1, 2019 via email

@talyz talyz mentioned this pull request Oct 1, 2019
Merged
10 tasks
@bgamari
Copy link
Contributor Author

bgamari commented Oct 2, 2019

Unfortunately I suspect that gitlab-ee fails with,

Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: rake aborted!
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: NoMethodError: undefined method `mysql?' for Gitlab::Database:Module
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ph31hylpcjdziv17iif1qjgnwy97hw8b-gitlab-ee-12.3.2/share/gitlab/config/initializers/active_record_mysql_timestamp.rb:7:in `<top (required)>'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:285:in `load'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:285:in `block in load'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:285:in `load'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/engine.rb:657:in `block in load_config_initializer'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/notifications.rb:170:in `instrument'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/engine.rb:656:in `load_config_initializer'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/engine.rb:614:in `block (2 levels) in <class:Engine>'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/engine.rb:613:in `each'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/engine.rb:613:in `block in <class:Engine>'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `instance_exec'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `run'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:61:in `block in run_initializers'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:50:in `each'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:50:in `tsort_each_child'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/initializable.rb:60:in `run_initializers'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/application.rb:361:in `initialize!'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ph31hylpcjdziv17iif1qjgnwy97hw8b-gitlab-ee-12.3.2/share/gitlab/config/environment.rb:6:in `<top (required)>'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/acrnaqnibcqfr9n4x5zdfpvbiyc9g4nd-ruby2.5.5-activesupport-5.2.3/lib/ruby/gems/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/application.rb:337:in `require_environment!'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/ihx2vzc5qnzlq31m4wm2x4drpr8v88jn-ruby2.5.5-railties-5.2.3/lib/ruby/gems/2.5.0/gems/railties-5.2.3/lib/rails/application.rb:520:in `block in run_tasks_blocks'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: /nix/store/488nkhl1ys627sch7mjmi0kf30jhng83-gitlab-env-12.3.2/lib/ruby/gems/2.5.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: Tasks: TOP => db:migrate => db:load_config => environment
Oct 02 14:01:45 gitlab.haskell.org z0x511y6dv9fzi5an58l7j7n5xyandvn-unit-script-gitlab-pre-start[18032]: (See full trace by running task with --trace)

@globin
Copy link
Member

globin commented Oct 2, 2019 •
edited
Loading

MySQL support has been removed with 12.3, as far as I remember.

Edit: 12.1 even: https://about.gitlab.com/2019/06/27/removing-mysql-support/

@bgamari
Copy link
Contributor Author

bgamari commented Oct 2, 2019

Indeed, it looks like the problem was stale initializers in /run/gitlab/config/initializers. Perhaps these should be wiped during startup?

@bgamari
Copy link
Contributor Author

bgamari commented Oct 2, 2019

I don't know if this is related but I am seeing migration issues with gitlab-ee.

@bgamari
Copy link
Contributor Author

bgamari commented Oct 2, 2019

Closing in favor of #70216.

@bgamari bgamari closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin

Assignees
No one assigned
Labels
1.severity: blocker This is preventing another PR or issue from being completed 1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @worldofpeace @flokli @globin