Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdrm: Add patch to fix musl build. Fixes #66441 #69270

Merged
merged 1 commit into from Sep 23, 2019
Merged

libdrm: Add patch to fix musl build. Fixes #66441 #69270

merged 1 commit into from Sep 23, 2019

Conversation

matthewbauer
Copy link
Member

(cherry picked from commit b577340)

Co-authored-by: Matthew Bauer mjbauer@gmail.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nh2 @matthewbauer
libdrm: Add patch to fix musl build. Fixes NixOS#66441
23399ff 
(cherry picked from commit b577340)

Co-authored-by: Matthew Bauer <mjbauer95@gmail.com>
@nh2 nh2 mentioned this pull request Sep 22, 2019
Closed
nh2
nh2 approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely!

@matthewbauer
Copy link
Member Author

@GrahamcOfBorg eval

@matthewbauer matthewbauer merged commit 783f925 into NixOS:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewbauer @nh2