Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplenote: 1.1.3 -> 1.8.0 #69266

Merged
merged 1 commit into from Sep 23, 2019
Merged

simplenote: 1.1.3 -> 1.8.0 #69266

merged 1 commit into from Sep 23, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Sep 22, 2019

Motivation for this change

I wanted to take a look at Simplenote and the first thing it did was say there was a new version I needed to download manually (1.3.0, iirc). So I check the website, and it's up to 1.8.0! And then I checked nixpkgs issues to make sure nobody else had already submitted one before I wasted time (wouldn't be the first time, not even the first time this week...) and the latest was an unmerged 1.5.0 from April

Things done

I did not run nix-review because it is broken for me right now??

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@worldofpeace worldofpeace merged commit a345e17 into NixOS:master Sep 23, 2019
@worldofpeace
Copy link
Contributor

Thanks for updating this @Kiwi ❤️

@Kiwi Kiwi deleted the simplenote-1.8.0 branch November 28, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants