Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualboxGuestAdditions: Fix clipboard integration. #69306

Merged
merged 1 commit into from Sep 25, 2019
Merged

virtualboxGuestAdditions: Fix clipboard integration. #69306

merged 1 commit into from Sep 25, 2019

Conversation

ambrop72
Copy link
Contributor

VBoxClient needs a RUNPATH entry to dlopen libXfixes successfully. Otherwise VBoxClient --clipboard just exits silently.

Theoretically it would be possible to test this and other integration features in the automated tests, but it would need quite some setup because currently the tests don't even try a graphical guest and I don't see a readily available mechanism to execute commands in the VirtualBox guest.

Motivation for this change

Make clipboard integration work (#65542).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ambrop72
virtualboxGuestAdditions: Fix clipboard integration.
7dcef37 
VBoxClient needs a RUNPATH entry to dlopen libXfixes successfully.

Fixes NixOS#65542
@ambrop72 ambrop72 mentioned this pull request Sep 23, 2019
Closed
@ofborg ofborg bot requested a review from svanderburg September 23, 2019 16:34
@flokli
Copy link
Contributor

flokli commented Sep 24, 2019

@GrahamcOfBorg test virtualbox

@flokli
Copy link
Contributor

flokli commented Sep 25, 2019

I tested this manually, clipboard integration worked in both directions. Thanks!

@flokli flokli merged commit 08a1aa4 into NixOS:master Sep 25, 2019
@flokli
Copy link
Contributor

flokli commented Sep 25, 2019

Cherry-picked to 19.09 in 5d92232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrop72 @flokli