Replace uses of splitString for splitting version strings #69345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
requested review from
edolstra,
matthewbauer and
nbp
as code owners
joachifm
changed the title
|
@GrahamcOfBorg eval |
ofborg
bot
added
6.topic: lua
6.topic: nixos
6.topic: rust
8.has: module (update)
labels
joachifm
changed the title
|
Losely related #68951 |
Quoting from the splitString docstring: NOTE: this function is not performant and should never be used. This replaces trivial uses of splitString for splitting version strings with the (potentially builtin) splitVersion.
joachifm
force-pushed
the
feat/split-version
branch
from
9135e3e
to
bad07df
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting from the splitString docstring:
This replaces trivial uses of splitString for splitting version
strings with the (potentially builtin) splitVersion.
I believe all the substitutions to be equivalent but have yet to verify.