Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/network: replace deprecated DHCP=both by DHCP=yes #69346

Merged
merged 1 commit into from Sep 24, 2019
Merged

nixos/network: replace deprecated DHCP=both by DHCP=yes #69346

merged 1 commit into from Sep 24, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Systemd 243 complains:

Sep 24 11:27:41 neon systemd-networkd[30216]: /etc/systemd/network/99-main.network:4: DHCP=both is deprecated, please use DHCP=yes instead.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Not sure who to cc

@globin globin self-assigned this Sep 24, 2019
@teto
Copy link
Member

teto commented Sep 24, 2019

the both meant ipv4 + ipv6 and now yes does the same ? is that it ?

@globin globin merged commit 6b87fb6 into NixOS:master Sep 24, 2019
@globin
Copy link
Member

globin commented Sep 24, 2019

Correct.

Backported in f96eaba

@rvolosatovs rvolosatovs deleted the fix/systemd-dhcp branch September 24, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@globin globin

Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @teto @globin