-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl-gui: init at 0.4 #69343
youtube-dl-gui: init at 0.4 #69343
Conversation
@GrahamcOfBorg build youtube-dl-gui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Have you tested it? It seems not to work.
I tested it briefly and thought it worked. I did see the downloading youtube-dl but then it went away when I added |
I've had a look and this finds it's |
Ideally we want a way we could force config options from the command line, as when we could make a wrapper that supplies the correct path to the youtube-dl program |
The best solution would be an upstream solution to disable automatic updates at buildtime since we want always our packaged version. I will create an issue there. I think this state is usable and can be merged. It can later be improved. Thanks for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for now
I'll make a comment in the code and remove |
was going to make an issue but MrS0m30n3/youtube-dl-gui#380 is worrying. |
oh no. then we might not add an unmaintained package with issue. I hope there will be an active fork or another GUI.
no. but i did now. I selected "mp3" as format and added a youtube video. It was downloaded 100% as webm and then status error. I can play the webm, but it has no image, just audio. Same with vorbis and m4a. When selecting webm, the video has no audio. mp4 works. it is the default. maybe the ffmpeg package is missing codecs? |
failing for me with:
|
There is still no popular, maintained fork. We should just close this. |
There's https://github.com/axcore/tartube for anyone looking for alterantives. |
Motivation for this change
Fixes #69334
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)@davidak