Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl-gui: init at 0.4 #69343

Closed
wants to merge 1 commit into from
Closed

Conversation

alexarice
Copy link
Contributor

Motivation for this change

Fixes #69334

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak

@alexarice
Copy link
Contributor Author

@GrahamcOfBorg build youtube-dl-gui

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Have you tested it? It seems not to work.

@davidak
Copy link
Member

davidak commented Sep 25, 2019

I was able to run the program, add URLs to download, but when i hit start,

it "download latest youtube-dl" (should use packaged) and tries to download the videos. That fails.

Screenshot from 2019-09-25 02-00-35

Screenshot from 2019-09-25 02-05-05

When i hit reload, the download begins sucessfully!

Screenshot from 2019-09-25 02-08-50

@alexarice
Copy link
Contributor Author

I tested it briefly and thought it worked. I did see the downloading youtube-dl but then it went away when I added youtube-dl to propagated build inputs. Maybe mine had just managed to already download it and it needs to be added to the path instead. I'll have an investigate

@alexarice
Copy link
Contributor Author

I've had a look and this finds it's youtube-dl program using it's config file and I can't see any nice way to be able to pass config items in as the config file lives in the home directory. Not sure what is the best way to solve this

@alexarice
Copy link
Contributor Author

Ideally we want a way we could force config options from the command line, as when we could make a wrapper that supplies the correct path to the youtube-dl program

@davidak
Copy link
Member

davidak commented Sep 26, 2019

The best solution would be an upstream solution to disable automatic updates at buildtime since we want always our packaged version. I will create an issue there.

I think this state is usable and can be merged. It can later be improved.

Thanks for your work!

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now

@alexarice
Copy link
Contributor Author

I'll make a comment in the code and remove youtube-dl from propagatedBuildInputs as it doesn't find it anyway

@alexarice
Copy link
Contributor Author

was going to make an issue but MrS0m30n3/youtube-dl-gui#380 is worrying.
On a side note did you manage to test the ffmpeg stuff?

@davidak
Copy link
Member

davidak commented Sep 26, 2019

MrS0m30n3/youtube-dl-gui#380 is worrying.

oh no. then we might not add an unmaintained package with issue.

I hope there will be an active fork or another GUI.

did you manage to test the ffmpeg stuff?

no. but i did now.

I selected "mp3" as format and added a youtube video. It was downloaded 100% as webm and then status error. I can play the webm, but it has no image, just audio. Same with vorbis and m4a.

When selecting webm, the video has no audio.

mp4 works. it is the default.

maybe the ffmpeg package is missing codecs?

@Lassulus
Copy link
Member

Lassulus commented Dec 8, 2019

failing for me with:

builder for '/nix/store/jqn38icyy79rd0l3whwkdav3ddmn4ih2-python2.7-youtube-dl-gui-0.4.drv' failed with exit code 1; last 10 log lines:
  unpacking sources
  unpacking source archive /nix/store/77qdqidp5adszh8p86xgm26wwdmki2kc-source
  source root is source
  setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/youtube_dl_gui/widgets.py
  patching sources
  configuring
  no configure script, doing nothing
  building
  Executing setuptoolsBuildPhase
  No module named wx
cannot build derivation '/nix/store/c55bf68ads4q1vmk8031fc27d42znq1k-env.drv': 1 dependencies couldn't be built

@davidak
Copy link
Member

davidak commented Dec 8, 2019

There is still no popular, maintained fork. We should just close this.

@pbogdan
Copy link
Member

pbogdan commented Dec 8, 2019

There's https://github.com/axcore/tartube for anyone looking for alterantives.

@alexarice alexarice closed this Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package youtube-dl-gui
4 participants