Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: use buildGoPackage in packages which vendor dependencies #69229

Merged
merged 15 commits into from Sep 22, 2019
Merged

treewide: use buildGoPackage in packages which vendor dependencies #69229

merged 15 commits into from Sep 22, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 21, 2019

Motivation for this change

Use buildGoPackage in packages which vendor its dependencies. buildGoModule uses a fixed-output derivation which introduces impurities (see NixOS/nix#2270)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Sep 21, 2019

@GrahamcOfBorg build git-lfs elfinfo vault lazydocker wallutils systemd-journal2gelf miniflux certigo dex-oidc mkcert golangci-lint rclone kubeless cointop

@adisbladis adisbladis merged commit 17bf171 into NixOS:master Sep 22, 2019
@marsam marsam deleted the use-buildGoPackage branch September 22, 2019 16:13
@marsam marsam mentioned this pull request Sep 22, 2019
Closed
@alexarice alexarice mentioned this pull request Sep 22, 2019
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 22, 2019
@adisbladis @dtzWill
Merge pull request NixOS#69229 from marsam/use-buildGoPackage
0a1d3a6 
treewide: use buildGoPackage in packages which vendor dependencies
(cherry picked from commit 17bf171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @adisbladis