Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enums in Records #223

Closed
RobertBaruch opened this issue Sep 21, 2019 · 1 comment
Closed

Consider enums in Records #223

RobertBaruch opened this issue Sep 21, 2019 · 1 comment
Labels
Milestone

Comments

@RobertBaruch
Copy link

Instead of:

class EnumItem(Enum):
  THING1 = 0
  THING2 = 1
class Bag(Layout):
  def __init__(self):
    super().__init__([
      ("thing", Signal.enum(EnumItem).shape())
    ])

Maybe:

class Bag(Layout):
  def __init__(self):
    super().__init__([
      ("thing", EnumItem)
    ])

With the understanding that fanning an element in requires the "inactive" outputs to be zero. This can inform the design of the enumerated class:

class EnumItem(Enum):
  NONE = 0
  THING1 =1
  THING2 = 2
@whitequark
Copy link
Contributor

Reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants