hyperv-daemons: fix binary location to stop error log spam #69299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 24, 2019
| @@ -31,8 +41,7 @@ let | |||
| ''; | |||
|
|
|||
| postFixup = '' | |||
| # kvp needs to be able to find the script(s) | |||
| wrapProgram $out/bin/hv_kvp_daemon --prefix PATH : $out/bin | |||
| wrapProgram $out/bin/hv_kvp_daemon --prefix PATH : ${lib.makeBinPath [ gawk iproute ]} | |||
There was a problem hiding this comment.
should this list not also include $out/bin?
There was a problem hiding this comment.
We patch the paths earlier, but in order to not fail spectacularly in the future if things change, I've added both bin and libexec. Thanks.
peterhoeg
force-pushed
the
f/hv_master
branch
from
f6f1cfb
to
a5872e8
Compare
|
@GrahamcOfBorg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Due to incorrect paths, we get a lot of log spam - this fixes that.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @