Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zabbixServer: move pid file from default (/tmp) to /run/zabbix … #69297

Merged
merged 1 commit into from Sep 25, 2019
Merged

nixos/zabbixServer: move pid file from default (/tmp) to /run/zabbix … #69297

merged 1 commit into from Sep 25, 2019

Conversation

aanderse
Copy link
Member

…to avoid issues with PrivateTmp=true

Motivation for this change
sudo -u zabbix /nix/store/c2byq8pqcka13mgzj38cnapvsl8f0byh-zabbix-server-4.2.3/sbin/zabbix_server -R log_level_increase="http poller"
zabbix_server [110889]: cannot open PID file [/tmp/zabbix_server.pid]: [2] No such file or directory

Due to usage of PrivateTmp=true in the systemd service zabbix behavior cannot be modified at runtime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut mmahut merged commit a28f136 into NixOS:master Sep 25, 2019
@aanderse aanderse deleted the zabbix branch September 25, 2019 19:35
@aanderse
Copy link
Member Author

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @mmahut