Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: add pager to environment #69294

Merged
merged 1 commit into from Sep 23, 2019
Merged

sage: add pager to environment #69294

merged 1 commit into from Sep 23, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 23, 2019

Motivation for this change

Temporary fixup for a transient issue (not sure why it is transient) while waiting for an upstream fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Temporary fixup while waiting for an upstream fix.
@timokau timokau merged commit 94a84b8 into NixOS:master Sep 23, 2019
@timokau timokau deleted the sage-add-pager branch September 23, 2019 15:09
@timokau timokau mentioned this pull request Oct 4, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant