Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iso-image: add loopback.cfg support to boot iso from grub #69214

Merged
merged 1 commit into from Oct 4, 2019
Merged

iso-image: add loopback.cfg support to boot iso from grub #69214

merged 1 commit into from Oct 4, 2019

Conversation

Lassulus
Copy link
Member

Motivation for this change

this feature was requested here: #67627

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Lassulus Lassulus changed the title iso-image: add loopback.cfg support to boot iso from grub WIP: iso-image: add loopback.cfg support to boot iso from grub Sep 24, 2019
@Lassulus
Copy link
Member Author

some computers have the usb device appear to late, I will try to wait for them

@Lassulus Lassulus changed the title WIP: iso-image: add loopback.cfg support to boot iso from grub iso-image: add loopback.cfg support to boot iso from grub Sep 24, 2019
@Lassulus Lassulus changed the title iso-image: add loopback.cfg support to boot iso from grub WIP: iso-image: add loopback.cfg support to boot iso from grub Sep 24, 2019
kmein
kmein reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@kmein kmein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know how to properly wait until an external device containing ISOs is available (better than sleep 5)

@pille
Copy link

pille commented Sep 24, 2019

not really. other distros implement waiting with some kind of polling:

    for trial_number in 1 2 3; do
       	[ $trial_number -gt 1 ] && sleep 3
        ...

@Lassulus Lassulus changed the title WIP: iso-image: add loopback.cfg support to boot iso from grub iso-image: add loopback.cfg support to boot iso from grub Sep 25, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/64

@Lassulus Lassulus merged commit 9d04a64 into NixOS:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmein kmein kmein left review comments

@4z3 4z3 4z3 approved these changes

@samueldr samueldr Awaiting requested review from samueldr samueldr is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lassulus @pille @nixos-discourse @4z3 @kmein