Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstore: don't forward --show-trace #3104

Merged
merged 1 commit into from Sep 23, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 22, 2019

Fixes #3101

I didn't do much testing except make sure that it compiles.

What is a good way to test these type of changes without re-installing my system?

@edolstra
Copy link
Member

Just stop the running Nix daemon, start the new one, run a client program that connects to it.

@edolstra edolstra merged commit 02b4632 into NixOS:master Sep 23, 2019
@zimbatm zimbatm deleted the no-show-trace-forwarding branch September 23, 2019 11:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/development-environement-habbits-from-previous-distros/4797/4

@flokli
Copy link
Contributor

flokli commented Dec 29, 2019

@zimbatm did this fix somehow end up being backported to NixOS 19.09?

Just had somebody reporting this error on a pretty recent nixos stable…

@zimbatm
Copy link
Member Author

zimbatm commented Dec 30, 2019

It will be part of the next release of Nix

@flokli
Copy link
Contributor

flokli commented Dec 31, 2019

It already is part of Nix 2.3.1, but stable still is on 2.3. Do you see any reason not to backport the 2.3.1 bump to stable?

@zimbatm zimbatm mentioned this pull request Dec 31, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: ignoring the user-specified setting 'show-trace'
4 participants