Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-vendor: drop #69274

Merged
merged 1 commit into from Sep 23, 2019
Merged

cargo-vendor: drop #69274

merged 1 commit into from Sep 23, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 23, 2019

Cargo 1.37 imported cargo-vendor as built-in command [1]

[1] rust-lang/cargo#6869

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Cargo 1.37 imported `cargo-vendor` as built-in command [1]

[1] rust-lang/cargo#6869
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review no re-builds :)

@Mic92 Mic92 merged commit c73c32d into NixOS:master Sep 23, 2019
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Feb 28, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Feb 28, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Feb 28, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Feb 29, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Mar 4, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Mar 4, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
jonasnick pushed a commit to jonasnick/nix-bitcoin that referenced this pull request Mar 8, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
jonasnick pushed a commit to jonasnick/nix-bitcoin that referenced this pull request Mar 24, 2020
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
@marsam marsam deleted the drop-cargo-vendor branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants