Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.urllib3: 1.24.3 -> 1.25.5 #69329

Closed
wants to merge 1 commit into from
Closed

python.pkgs.urllib3: 1.24.3 -> 1.25.5 #69329

wants to merge 1 commit into from

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Sep 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [] Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmlb
Copy link
Contributor Author

mmlb commented Sep 23, 2019

I'm running through nix-review wip atm, there are a few failures so far but nothing that seems related to this upgrade.

@FRidh FRidh self-assigned this Sep 24, 2019
@FRidh
Copy link
Member

FRidh commented Oct 22, 2019

1.25.6 is in staging
038e940

@FRidh FRidh closed this Oct 22, 2019
@mmlb mmlb deleted the update-python.pkgs.urllib3 branch November 18, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants