Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.exfat-nofuse: 2018-04-16 -> 2019-09-06 #68647

Merged
merged 1 commit into from Sep 24, 2019
Merged

linuxPackages.exfat-nofuse: 2018-04-16 -> 2019-09-06 #68647

merged 1 commit into from Sep 24, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 13, 2019

Motivation for this change

Upstream repository is unmaintained since 2018, maintainership got taken
over by AdrianBan ( dorimanx/exfat-nofuse#145 (comment) )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [N/A] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

that would be me, i guess
cc @

@makefu
Copy link
Contributor Author

makefu commented Sep 13, 2019

@GrahamcOfBorg build linuxPackages.exfat-nofuse

disassembler
disassembler suggested changes Sep 14, 2019
View reviewed changes
pkgs/os-specific/linux/exfat/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/exfat/default.nix Outdated Show resolved Hide resolved
@makefu
linuxPackages.exfat-nofuse: 2018-04-16 -> 2019-09-06
8a6e2f5 
Upstream repository is unmaintained since 2018, maintainership got taken
over by AdrianBan ( dorimanx/exfat-nofuse#145 (comment) )
@makefu makefu force-pushed the pkgs/exfat-nofuse/change-upstream branch from f58a711 to 8a6e2f5 Compare September 16, 2019 12:09
@makefu
Copy link
Contributor Author

makefu commented Sep 16, 2019

This PR should solve all(tm) build errors related to exfat-nofuse in #68361

@makefu
Copy link
Contributor Author

makefu commented Sep 16, 2019

@GrahamcOfBorg build linuxPackages.exfat-nofuse linuxPackages_4_14.exfat-nofuse linuxPackages_4_19.exfat-nofuse linuxPackages_5_2.exfat-nofuse linuxPackages_5_1.exfat-nofuse linuxPackages_xen_dom0.exfat-nofuse

@bricewge bricewge mentioned this pull request Sep 21, 2019
Closed
@makefu
Copy link
Contributor Author

makefu commented Sep 23, 2019

builds timed out, not sure what happened there. let me retry

@makefu
Copy link
Contributor Author

makefu commented Sep 23, 2019

@GrahamcOfBorg build linuxPackages.exfat-nofuse linuxPackages_4_14.exfat-nofuse linuxPackages_4_19.exfat-nofuse linuxPackages_5_2.exfat-nofuse linuxPackages_5_1.exfat-nofuse linuxPackages_xen_dom0.exfat-nofuse

@makefu
Copy link
Contributor Author

makefu commented Sep 23, 2019

mh seems to try to compile all the kernels(tm).

@Mic92 Mic92 merged commit 8086e67 into NixOS:master Sep 24, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

[detached HEAD 630bffe] linuxPackages.exfat-nofuse: 2018-04-16 -> 2019-09-06
Author: makefu github@syntax-fehler.de
Date: Fri Sep 13 08:43:15 2019 +0200
1 file changed, 5 insertions(+), 14 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makefu @Mic92 @disassembler