Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-openvpn: init at 0.0.1 #69301

Merged
merged 2 commits into from Sep 24, 2019
Merged

check-openvpn: init at 0.0.1 #69301

merged 2 commits into from Sep 24, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Check for openvpn. Been using this for a long time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

alexarice
alexarice reviewed Sep 23, 2019
View reviewed changes
pkgs/servers/monitoring/plugins/openvpn.nix Outdated
# no tests
doCheck = false;

meta = with stdenv.lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to import stdenv. You can directly import lib instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@peterhoeg peterhoeg merged commit 5426932 into NixOS:master Sep 24, 2019
@peterhoeg peterhoeg deleted the p/check-openvpn branch September 24, 2019 06:53
@peterhoeg peterhoeg restored the p/check-openvpn branch September 24, 2019 20:28
@peterhoeg peterhoeg deleted the p/check-openvpn branch September 24, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @alexarice