make the set_max_delay value a string #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `max_delay` was 5.3, the verilog was `(* \nmigen.vivado.max_delay = 32'd5 *)` With this change, the verilog is `(* \nmigen.vivado.max_delay = "5.3" *)`
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 82.32% 82.32%
=======================================
Files 33 33
Lines 5489 5489
Branches 1174 1174
=======================================
Hits 4519 4519
Misses 836 836
Partials 134 134Continue to review full report at Codecov.
|
|
Actually, there's one more change I want to do to it. Since everywhere else in nMigen frequencies are specified in hertz, then max delay should be specified in seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
max_input_delaywas set to 5.3, the verilog was(* \nmigen.vivado.max_delay = 32'd5 *)With this change, the verilog is
(* \nmigen.vivado.max_delay = "5.3" *)