Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openems: init at 0.35.0 #69262

Closed
wants to merge 5 commits into from
Closed

openems: init at 0.35.0 #69262

wants to merge 5 commits into from

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Sep 22, 2019

OpenEMS is an open-source electromagnetic field solver that uses the FDTD method.

This commit adds a number of related packages as dependencies for OpenEMS, including appcsxcad, csxcad, fparser, hyp2mat, and qcsxcad.

Additionally, it makes a few changes to existing, dependent packages:

  1. Adds QT GUI support to VTK.
  2. Adds gl2ps as an optional dependency of octave, which is needed for certain OpenEMS plots.
  3. Adds openmpi C++ libraries.
  4. Makes cgal headers and libraries discoverable by OpenEMS.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@matthuszagh
Copy link
Contributor Author

Let me know if I need to do something on my end for this. I'm not really sure what that error message means.

@matthuszagh
Copy link
Contributor Author

I've updated this to include the optional python interface.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to conform to CONTRIBUTING.md, please make it so that roughly 1 commit = 1 package.

appcsxcad: init at 0.2.2
csxcad: init at 0.6.2
....

pkgs/applications/science/electronics/openems/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-csxcad/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-openems/default.nix Outdated Show resolved Hide resolved
@matthuszagh
Copy link
Contributor Author

Changes implemented. This currently fails to build because of qscintilla/octave, so just waiting on this pr.

@matthuszagh
Copy link
Contributor Author

Octave has been fixed upstream. I've fixed the merge conflict and this now builds correctly.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@matthuszagh
Copy link
Contributor Author

Just a heads up, I believe the eval should succeed now that my name is in the maintainers list.

@matthuszagh
Copy link
Contributor Author

@jonringer I've fixed the merge conflicts and got the package working with some other package updates that occurred since the original PR. Please let me know any issues etc. Thanks!

@jonringer
Copy link
Contributor

I would break this PR apart into many. As it stands, it would take a lot to review and I think the process would be painful for the both of us.

@matthuszagh
Copy link
Contributor Author

Sure, more than happy to structure this in a way that's easier on you all. How do you suggest I break it up? Roughly, each of those commits should be a separate PR? What's the best way to reference that all these changes are made to support the addition of openems? Just state that and link to the openems webpage? My only concern is that the need for some of these changes may seem less apparent outside the context of openems.

@jonringer
Copy link
Contributor

jonringer commented Apr 6, 2020

#78772 is a good example.

Personally, i would break each commit into it's own separate PR (but only if it builds). So, I would cherry-pick the individual commits (which can be built off master), and when they get merged in, just drop the commits from this PR. Eventually, this should just include the openems: init at XXXX commit.

EDIT: grammar

@matthuszagh matthuszagh mentioned this pull request Apr 7, 2020
10 tasks
@matthuszagh
Copy link
Contributor Author

@jonringer thanks so much for the guidance on this. I've submitted the first PR. Others to follow that merge.

@jonringer
Copy link
Contributor

@matthuszagh if you want to tag me for reviews, feel free to do so

@doronbehar
Copy link
Contributor

There are merge conflicts.

@matthuszagh
Copy link
Contributor Author

@doronbehar yes, this isn't ready to merge yet. I'm resubmitting it as a series of individual PRs. When there is one commit left, I'll rebase.

@jonringer
Copy link
Contributor

I think most of these are merged, should we close?

@matthuszagh
Copy link
Contributor Author

Sure, fine by me. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants