Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutt: 1.12.1 -> 1.12.2 #69239

Merged
merged 1 commit into from Sep 22, 2019
Merged

mutt: 1.12.1 -> 1.12.2 #69239

merged 1 commit into from Sep 22, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[4 built, 12 copied (1.7 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69239
2 package were build:
grepm mutt

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested my workflow in mutt and all the executable.

@Mic92 Mic92 merged commit c210392 into NixOS:master Sep 22, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2019
mutt: 1.12.1 -> 1.12.2
(cherry picked from commit c210392)
@matthiasbeyer matthiasbeyer deleted the update-mutt branch November 9, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants