Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hadolint: fix build by disabling static linking #69311

Merged
merged 1 commit into from Sep 24, 2019
Merged

haskellPackages.hadolint: fix build by disabling static linking #69311

merged 1 commit into from Sep 24, 2019

Conversation

liff
Copy link
Contributor

@liff liff commented Sep 23, 2019

Motivation for this change

hadolint.cabal uses ld-options: -static -pthread on Linux by default. That doesn’t work on NixOS, so remove the ld-options line from the Cabal file.

Followed the video tutorial, hoping I got this right.

This comment also seemed relevant/helpful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout
Copy link
Member

@liff Thanks for creating this PR. Your solution here is correct.

I've confirmed that hadolint is able to be compiled.

@peti This should be ready to merge in.

@Mic92 Mic92 merged commit 7da3dbc into NixOS:haskell-updates Sep 24, 2019
@liff liff deleted the fix/haskellPackages.hadolint branch February 16, 2021 09:01
@liff liff mentioned this pull request Feb 16, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liff @cdepillabout @Mic92