Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: fix build on darwin #73379

Merged
merged 2 commits into from Nov 14, 2019
Merged

mpv: fix build on darwin #73379

merged 2 commits into from Nov 14, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 14, 2019

Motivation for this change

Fixes #73367

cc: @toonn

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 14, 2019
@jonringer
Copy link
Contributor

@GrahamcOfBorg build mpv sndio

jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toonn
Copy link
Contributor

toonn commented Nov 14, 2019

Hmm, I'm trying to test this but I guess I'm messing up the overlay?

self: super:
{ mpv = super.callPackage ~/src/nixpkgs/pkgs/applications/video/mpv/default.nix {};
  sndio = super.callPackage ~/src/nixpkgs/pkgs/misc/sndio/default.nix {};
}

Error when building is error: cannot coerce a function to a string, at /nix/store/4b1b8qzvpp69lb12s3pv9qdz753rwqwj-nixpkgs-20.03pre201329.f1682a7f126/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:191:11.

@fpletz fpletz merged commit c46d15d into NixOS:master Nov 14, 2019
@toonn
Copy link
Contributor

toonn commented Nov 14, 2019

Realized just that output isn't very useful, here's the --show-trace output:

toonn@terra ~> nix-shell -p mpv --show-trace
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
error: while evaluating the attribute 'buildInputs' of the derivation 'shell' at /nix/store/4b1b8qzvpp69lb12s3pv9qdz753rwqwj-nixpkgs-20.03pre201329.f1682a7f126/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating the attribute 'buildInputs' of the derivation 'mpv-0.30.0' at /nix/store/4b1b8qzvpp69lb12s3pv9qdz753rwqwj-nixpkgs-20.03pre201329.f1682a7f126/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:191:11:
cannot coerce a function to a string, at /nix/store/4b1b8qzvpp69lb12s3pv9qdz753rwqwj-nixpkgs-20.03pre201329.f1682a7f126/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:191:11

@marsam marsam deleted the fix-mpv-darwin branch November 14, 2019 13:25
@marsam
Copy link
Contributor Author

marsam commented Nov 14, 2019

@toonn sorry, besides the basic usage, I don't know much about overlays.
I usually test PRs with the same method as worldofpeace https://youtu.be/siR3pvmxFlU?t=2057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

@ivan ivan Awaiting requested review from ivan

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpv: Killed by SIGABRT because of missing libsndio.7.0.dylib
4 participants
@marsam @jonringer @toonn @fpletz