Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.9.5 -> 1.9.6 #73415

Merged
merged 1 commit into from Nov 15, 2019
Merged

gitea: 1.9.5 -> 1.9.6 #73415

merged 1 commit into from Nov 15, 2019

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Nov 14, 2019 •
edited

Motivation for this change

Gitea Bugfix release: https://blog.gitea.io/2019/11/gitea-1.9.6-is-released/

Since 1.10 was also released, maybe we should drop this pr in favour of 1.10? See #73416 for the 1.10.0 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from disassembler and ehmry November 14, 2019 19:31
@etu
Copy link
Contributor

etu commented Nov 15, 2019

@GrahamcOfBorg test gitea

I'm thinking that maybe we want 1.9.5 -> 1.9.6 and 1.9.6 -> 1.10.0? We need to decide if we want to backport 1.10.0 to stable or if we want to stick it to the 1.9.X series. If we have the latter we should probably get 1.9.6 in master to be able to cherry-pick that commit.

@etu etu merged commit 962783e into NixOS:master Nov 15, 2019
@etu etu mentioned this pull request Nov 15, 2019
Merged
10 tasks
@flokli flokli mentioned this pull request Nov 17, 2019
Merged
10 tasks
@kolaente kolaente deleted the update/gitea-1.9.6 branch November 18, 2019 19:30
@kolaente
Copy link
Member Author

kolaente commented Nov 18, 2019 •
edited

IMHO we should put 1.10. in stable, since 1.9.X won't get much support now because 1.10. is out. We (Gitea) simply don't have the resources to provide an LTS version, we're only a community open source project.

@etu etu mentioned this pull request Nov 19, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler Awaiting requested review from disassembler

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolaente @etu