Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] libpcap, tcpdump: 1.9.1 and 4.9.3 for many security fixes #72028

Merged
merged 2 commits into from Nov 15, 2019
Merged

[r19.09] libpcap, tcpdump: 1.9.1 and 4.9.3 for many security fixes #72028

merged 2 commits into from Nov 15, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 26, 2019 •
edited

Motivation for this change

Backport of #70249

There seem to be too many issues to address this through patches.

Too many reverse dependencies for me to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from globin and fpletz October 26, 2019 14:28
@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

@GrahamcOfBorg build tcpdump

@ckauhaus
Copy link
Contributor

waiting for ofBorg...

@grahamc I've trouble interpreting the graphs at https://monitoring.nix.ci/ -- is ofBorg working normally or is it stuck?

@FRidh FRidh added this to Needs review in Staging (stable) Nov 3, 2019
@ckauhaus
Copy link
Contributor

Compiled & smoke-tested both on NixOS and Darwin.

@ckauhaus ckauhaus merged commit e1cc8ff into NixOS:staging-19.09 Nov 15, 2019
Staging (stable) automation moved this from Needs review to Done Nov 15, 2019
@c0bw3b c0bw3b mentioned this pull request Dec 4, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @ckauhaus @dtzWill