Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernix: v0.2.0 #73385

Merged
merged 1 commit into from May 1, 2020
Merged

kubernix: v0.2.0 #73385

merged 1 commit into from May 1, 2020

Conversation

saschagrunert
Copy link
Member

Motivation for this change

Add kubernix to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert saschagrunert mentioned this pull request Nov 14, 2019
Closed
@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build kubernix

@saschagrunert saschagrunert mentioned this pull request Nov 15, 2019
Closed
@jonringer
Copy link
Contributor

oh, I'm not 100% sure on how to scope tests in rust, I just noticed that all the config::tests ones passed. I knew the command wasn't right :(

@jonringer
Copy link
Contributor

sorry to bother @grahamc , but I'm not really sure how to scope cargo tests to just a subset of a test suite

@jonringer
Copy link
Contributor

also, it's hard to find documentation on the matter

@saschagrunert
Copy link
Member Author

also, it's hard to find documentation on the matter

Unfortunately its not that easily possible with the 0.2.0 release. I would suggest in changing this to the next version, where I would split up the independent tests that we can execute them here.

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build kubernix

zowoq
zowoq reviewed Apr 29, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the tests in the next release sounds fine.

pkgs/applications/networking/cluster/kubernix/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kubernix/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kubernix/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kubernix/default.nix Outdated Show resolved Hide resolved
@saschagrunert
Copy link
Member Author

Implemented the review suggestions and rebased on top of the latest master.

@saschagrunert
kubernix: v0.2.0
c07a467 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

@ofborg eval

Looks like the bot got stuck; sorry about that.

zowoq
zowoq approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

@marsam marsam merged commit 38230fe into NixOS:master May 1, 2020
@saschagrunert saschagrunert deleted the kubernix branch May 1, 2020 06:55
@PanAeon
Copy link
Contributor

PanAeon commented May 6, 2020

Works against 20.03.1619.ab3adfe1c76 with obligatory cargoSha256 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @jonringer @cole-h @PanAeon @zowoq @marsam