Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add cptMikky #73388

Closed
wants to merge 1 commit into from
Closed

maintainers: add cptMikky #73388

wants to merge 1 commit into from

Conversation

jficz
Copy link
Contributor

@jficz jficz commented Nov 14, 2019

Motivation for this change

add me as a maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Nov 14, 2019

Are there any packages you will maintain?

@jficz
Copy link
Contributor Author

jficz commented Nov 14, 2019

Are there any packages you will maintain?

yes, I'm working on #73372 and plan to create a few others

@FRidh
Copy link
Member

FRidh commented Nov 14, 2019

Please add this commit to that PR otherwise evaluation will break if it goes in before this is in.

A PR should be mergeable by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants