New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkPhase for pipenv #73349
Add checkPhase for pipenv #73349
Conversation
This is to prevent regressions such as #73254 by using pipenv to install a simple Python package, thus testing that pipenv was built correctly. Many thanks to @infinisil and @domenkozar for hand-holding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will this test install to? We do not want it to create any additional content in $out
.
It seems $out does not get polluted. Which, according to my very basic understanding, is expected, otherwise most packages'
|
It seems that
|
We need an egg to install to test that pipenv works. Instead of downloading & installing pyjokes, let's use wheel since we already have it. Refs #73349 (comment)
@GrahamcOfBorg build pipenv |
ugh should have squashed these commits... |
Motivation for this change
This is to prevent regressions such as #73254
by using pipenv to install a simple Python package, thus testing
that pipenv was built correctly.
I tested the patch locally against nixpgs master (pipenv built successfully) and against nixpgs 19.09 (pipenv build failed, as expected, with
ModuleNotFoundError: No module named 'pip._internal.main'
).Refs #73254
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @FRidh
Many thanks to @infinisil and @domenkozar for hand-holding!