zcash: 1.0.13 -> 2.1.0-1 #73353
Merged
zcash: 1.0.13 -> 2.1.0-1 #73353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Nov 13, 2019
tkerber
force-pushed
the
zcash-2.1.0-1
branch
from
e62bd83
to
e8a5012
Compare
rht
reviewed
Nov 13, 2019
|
|
||
| installPhase = '' | ||
| mkdir -p $out/lib | ||
| cp target/release/librustzcash.a $out/lib/ | ||
| mkdir -p $out/include | ||
| cp include/librustzcash.h $out/include/ | ||
| cp librustzcash/include/librustzcash.h $out/include/ |
There was a problem hiding this comment.
Was there an update in how librustzcash was fetched from github?
There was a problem hiding this comment.
No, it now has multiple sub-projects, the main one of which is in the directory librustzcash.
rht
reviewed
Nov 13, 2019
| ''; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
It is not. I should have added a comment in hindsight. Without this line, it runs cargo test in their rust workspace. These appear quite substantial (and single threaded) - I left them running for the best part of yesterday on my pc before giving up and going to bed, hence why I felt it best to disable them.
|
This patch LGTM. |
tkerber
force-pushed
the
zcash-2.1.0-1
branch
from
e8a5012
to
cc1568d
Compare
|
Minor delta: I removed the dependency on |
Lassulus
reviewed
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Zcash is severely outdated, and is incompatible with the live network.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @rht