Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-helm: 2.15.1 -> 3.0.0 #73351

Merged
merged 1 commit into from Nov 14, 2019
Merged

kubernetes-helm: 2.15.1 -> 3.0.0 #73351

merged 1 commit into from Nov 14, 2019

Conversation

saschagrunert
Copy link
Member

Motivation for this change

Update helm to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rlupton20 @edude03

@saschagrunert
kubernetes-helm: 2.15.1 -> 3.0.0
7b2e483 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@rlupton20
Copy link
Contributor

Looks good!

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build kubernetes-helm

@ofborg ofborg bot requested review from kalbasit and rlupton20 November 13, 2019 16:28
rlupton20
rlupton20 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@rlupton20 rlupton20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executables show usage

[5 built, 2 copied (71.6 MiB), 66.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73351
2 package were build:
helmfile kubernetes-helm

expression looks a lot cleaner! :)

@jonringer
Copy link
Contributor

@GrahamcOfBorg build helmfile kubernetes-helm

@jonringer jonringer merged commit 65e7d9c into NixOS:master Nov 14, 2019
@saschagrunert saschagrunert deleted the helm-3 branch November 14, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@rlupton20 rlupton20 rlupton20 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @rlupton20 @jonringer